Added new test case for bulk delete #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshil-Jani
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 71.95% 70.39% -1.56%
==========================================
Files 91 125 +34
Lines 8001 9290 +1289
==========================================
+ Hits 5757 6540 +783
- Misses 2244 2750 +506 ☔ View full report in Codecov by Sentry. |
Harshil-Jani
force-pushed
the
harshil/test-bulk-delete
branch
from
b305e58 to
b300889
Compare
|
Thanks! Try fixing it? |
|
Sure. Will spend some time this weekend to check if I can find anything. |
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
Harshil-Jani
force-pushed
the
harshil/test-bulk-delete
branch
from
b300889 to
991e81e
Compare
Harshil-Jani
changed the title
|
Updated the test case with correct usage. It's working as expected. Not a bug anymore. |
dblock
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
What was the usage mistake? Do we need to make the documentation cleaerer?
I see #873 (comment), let's talk about it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new test case for bulk delete
Issues Resolved
closes #873
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.