Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /cluster/stats in a backwards compatible way #851

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 25, 2024

Description

The /_cluster/stats endpoint exists now in all its glorious variations up to /_cluster/stats/indices/analysis/nodes/test-node which includes a metric (new), an index metric (new), and a node id (old). The generator added the metric and index metric in order, added a patch that swaps them to the end of the list to preserve backwards compatibility.

Adds insights, list and wlm APIs amongst others from spec.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock changed the title Ran nox -s generate. Fix /cluster/stats in a backwards compatible way Nov 25, 2024
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review November 25, 2024 20:27
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 54.60993% with 192 lines in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (ba715b9) to head (91298d9).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
opensearchpy/_async/plugins/replication.py 43.85% 32 Missing ⚠️
opensearchpy/plugins/replication.py 43.85% 32 Missing ⚠️
opensearchpy/_async/plugins/flow_framework.py 46.93% 26 Missing ⚠️
opensearchpy/plugins/flow_framework.py 46.93% 26 Missing ⚠️
opensearchpy/_async/client/wlm.py 50.00% 11 Missing ⚠️
opensearchpy/_async/plugins/ml.py 47.61% 11 Missing ⚠️
opensearchpy/client/wlm.py 50.00% 11 Missing ⚠️
opensearchpy/plugins/ml.py 47.61% 11 Missing ⚠️
opensearchpy/_async/plugins/asynchronous_search.py 57.89% 8 Missing ⚠️
opensearchpy/plugins/asynchronous_search.py 57.89% 8 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   71.95%   70.31%   -1.64%     
==========================================
  Files          91      125      +34     
  Lines        8001     9299    +1298     
==========================================
+ Hits         5757     6539     +782     
- Misses       2244     2760     +516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saimedhi saimedhi merged commit bf9add4 into opensearch-project:main Nov 25, 2024
39 of 41 checks passed
@dblock dblock deleted the generate-manually branch November 25, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants