Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated YAML REST tests known to fail. #838

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 24, 2024

Description

Preserving the tradition of skipping YAML REST tests that fail for reasons unknown.
I assume these pass in OpenSearch core, so they are likely hiding bugs in the client, but I could be wrong.

I rebuilt the list from scratch thinking there would be false positives, but there weren't. The new one here is OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/indices/get_settings/40_number_of_routing_shards[0] that fails only on 3.0 / main.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (ba715b9) to head (3913264).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   71.95%   70.34%   -1.61%     
==========================================
  Files          91      113      +22     
  Lines        8001     8896     +895     
==========================================
+ Hits         5757     6258     +501     
- Misses       2244     2638     +394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock added the skip-changelog Skips changelog verifier label Oct 24, 2024
@dblock dblock force-pushed the update-skip-tests branch 2 times, most recently from 601812d to e6333a4 Compare October 24, 2024 15:08
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock merged commit 6fa54a7 into opensearch-project:main Oct 24, 2024
41 of 42 checks passed
@dblock dblock deleted the update-skip-tests branch October 24, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants