Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the bucket aggregation. #797

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 15, 2024

Description

Finishes #663. This is a pretty trivial change, some day we can write a guide and a sample for aggs.

Issues Resolved

Closes #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (ba715b9) to head (fe930be).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   71.95%   70.30%   -1.65%     
==========================================
  Files          91      113      +22     
  Lines        8001     8868     +867     
==========================================
+ Hits         5757     6235     +478     
- Misses       2244     2633     +389     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi saimedhi merged commit def00fa into opensearch-project:main Aug 15, 2024
36 of 39 checks passed
@dblock dblock deleted the mckirk-patch-fixed branch August 15, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants