Allow the use of percent string in Bool.__and__ method

[Godefroy-Amaury]

Description

Allow the use of 50, "50" or "50%" as valid value for qx._min_should_match/min_should_match in the Bool.__and__ method.

Previously, if for any reason the qx._min_should_match was a string, a TypeError error was raise by the if len(qx.should) <= min_should_match:.

Still raise a ValueError if the given value is an invalid integer representation.

Issues Resolved

Closes #779

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Thanks! Add a test and a CHANGELOG entry, please?

It would be amazing if you could please look at https://github.com/opensearch-project/opensearch-api-specification as well and add tests there for this and other use-cases so we don't lose this functionality as we move towards more of this code being generated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (ba715b9) to head (b786504).
Report is 42 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   71.95%   70.69%   -1.26%     
==========================================
  Files          91      105      +14     
  Lines        8001     8621     +620     
==========================================
+ Hits         5757     6095     +338     
- Misses       2244     2526     +282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

Looking pretty good, thanks for the tests. See below for comments.

Please do fix DCO, git commit --amend -s and force push will do it.

[dblock]

Add PR number here.

[dblock]

I am worried that int() may do unexpected things like rounding a float for example.

Maybe we can just be explicit, check that the value ends with % and convert the rest?

[Godefroy-Amaury]

But having a float at this point is a bit of nonsense, no? Looking at the documentions, the min_should_match mean "i need at least X values" - or did I miss something? Maybe a round up/down to the nearest should be ok? (something like: int(round(float("3.14"), 0)) -> 3)

Indeed, I can only check for string that end up with a "%", but we'll lose the possibility to use int who has been cast as string. I let you have the final word. 👍

[dblock]

I think you misunderstood me, sorry.

I mean that if we rely on an exception to see if the value can be converted, then we might introduce undesired behavior.

$ python -c "print(int("3.14"))"
3

You can see that if I pass a value not accepted by the API it's happily coerced into an int, losing the actual value! That doesn't seem good :) It should be an error in this case, no?

[Godefroy-Amaury]

Oh, get it. If an invalid value is passed to the query, we don't want to magically (attempt to) fix it. 👍
Code and test has been updated.

[dblock]

Thanks for fixing this!