Code generated using native OpenAPI specification #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal and
florianvazelle
as code owners
|
This is generated code. @dblock, please review. Kindly approve if everything looks correct, but please do not merge. I'll give it one last check to make sure we haven't missed any minor details. Thank you! |
dblock
reviewed
Apr 17, 2024
dblock
previously approved these changes
Apr 17, 2024
In the follow-up PR, I'll update the generator to include any newly added namespaces in the changelog. |
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
commented
Apr 17, 2024
| @@ -22,7 +22,7 @@ | |||
| {% for p, info in api.params %} | |||
| {% if info.description %} | |||
| {% filter wordwrap(72, wrapstring="\n ") %} | |||
| :arg {{ p }}{% if info.deprecated and info.deprecation_message is defined %} (Deprecated: {{ info['deprecation_message'][:-1] }}.){% endif %}: {{ info.description }} {% if info.options and "Valid values: " not in info.description %}Valid choices are {{ info.options|join(", ") }}.{% endif %} | |||
| :arg {{ p }}{% if info.deprecated and info.deprecation_message is defined %} (Deprecated: {{ info['deprecation_message'][:-1] }}.){% endif %}: {{ info.description }} {% if info.options and "Valid values" not in info.description %}Valid choices are {{ info.options|join(", ") }}.{% endif %} | |||
| {% if info.default is defined %}{% if info.default is not none %}{% if info.default is sameas(false) %}Default is false.{% else %}Default is {{ info.default }}.{% endif %}{% endif %}{% endif %} | |||
There was a problem hiding this comment.
Made small modification to generator
dblock
previously approved these changes
Apr 17, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com>
|
@dblock, apologies for the inconvenience. I need your approval one last time before merging. Thank you. |
dblock
approved these changes
Apr 17, 2024
AbitraryYu
pushed a commit
to AbitraryYu/opensearch-py
that referenced
this pull request
Apr 22, 2024
…#724) * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com>
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
…#724) * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> * Code generated using native OpenAPI specification Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code generated using native OpenAPI specification
Issues Resolved
Related to #636
Related to #474
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.