-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified generator to generate plugins #700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5732 5732
Misses 2213 2213 ☔ View full report in Codecov by Sentry. |
Lint is failing. I will fix it in spec.
|
READY FOR REVIEW.
Currently facing issues with testing train_model, which are unrelated to the client. Followed documentation while writing tests.
|
762f46f
to
15cc46a
Compare
Signed-off-by: saimedhi <saimedhi@amazon.com>
15cc46a
to
39273af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works. After you merge this you should refactor it.
Replace is_plugin
by inheritance. Create a base class called Component
(or another name) and a new class called Plugin
inherits from it. Make Module
inherit from it as well. The extra functionality of a plugin or module goes into the child classes, and everything common into the base class.
Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: AbitraryYu <nikkoyhc@gmail.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Description
Modified the generator to generate plugins. Currently, it generates KNN APIs. I will add integration tests.
Issues Resolved
Closes #693
Closes #697
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.