Use .pylintrc files #654
Merged
Use .pylintrc files #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Cohen <markcoh@amazon.com>
…equires camel case instead of snake case Signed-off-by: Mark Cohen <markcoh@amazon.com>
macohen
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5731 5731
Misses 2214 2214 ☔ View full report in Codecov by Sentry. |
dblock
reviewed
Jan 19, 2024
| @@ -102,7 +102,11 @@ def lint(session: Any) -> None: | |||
| session.run("black", "--check", *SOURCE_FILES) | |||
| session.run("flake8", *SOURCE_FILES) | |||
|
|
|||
| lint_per_folder(session) | |||
| pylint_overrides = ["opensearchpy/", "test_opensearchpy/"] | |||
There was a problem hiding this comment.
Instead of this find all .pylintrc files under first level subfolders and run those?
|
The one thing I don't like about this solution is that each .pylintrc stands on its own. There's no way to inherit the config from a higher level folder so if max-line-length should be 240 across the whole project, it needs to be in each .pylintrc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
switches pylint to use .pylintrc configs instead of python generated pylint commands
Issues Resolved
#645
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.