Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint integration updates #643

Merged
merged 16 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated functions with missing docstrings or pylint ignore instructio…
…ns; added a utility to automatically add these ignore instructions to most functions that should be self-describing; rolled back some automatically generated code mistakenly changed

Signed-off-by: Mark Cohen <markcoh@amazon.com>
  • Loading branch information
macohen committed Dec 31, 2023
commit f3a0450818b84b8f70ea71eb681afa78aa47546a
7 changes: 6 additions & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
SOURCE_FILES = (
"setup.py",
"noxfile.py",
"opensearchpy/",
# "opensearchpy/",
"test_opensearchpy/",
"utils/",
"samples/",
Expand All @@ -43,6 +43,7 @@

@nox.session(python=["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]) # type: ignore
def test(session: Any) -> None:
# pylint: disable=missing-function-docstring
macohen marked this conversation as resolved.
Show resolved Hide resolved
session.install(".")
# ensure client can be imported without aiohttp
session.run("python", "-c", "import opensearchpy\nprint(opensearchpy.OpenSearch())")
Expand All @@ -59,6 +60,7 @@ def test(session: Any) -> None:

@nox.session(python=["3.7"]) # type: ignore
def format(session: Any) -> None:
# pylint: disable=missing-function-docstring
session.install(".")
session.install("black", "isort")

Expand All @@ -71,6 +73,7 @@ def format(session: Any) -> None:

@nox.session(python=["3.7"]) # type: ignore
def lint(session: Any) -> None:
# pylint: disable=missing-function-docstring
session.install(
"flake8",
"black",
Expand Down Expand Up @@ -110,6 +113,7 @@ def lint(session: Any) -> None:

@nox.session() # type: ignore
def docs(session: Any) -> None:
# pylint: disable=missing-function-docstring
session.install(".")
session.install(".[docs]")
with session.chdir("docs"):
Expand All @@ -118,6 +122,7 @@ def docs(session: Any) -> None:

@nox.session() # type: ignore
def generate(session: Any) -> None:
# pylint: disable=missing-function-docstring
session.install("-rdev-requirements.txt")
session.run("python", "utils/generate_api.py")
format(session)
Loading