Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps urllib3 from >=1.26.18 to >=1.26.18, <2 #632

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

saimedhi
Copy link
Collaborator

Description

Bumps urllib3 from >=1.26.18 to >=1.26.18, <2

Issues Resolved

Closes #628

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4e53d4) 72.12% compared to head (1cf9141) 74.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   72.12%   74.41%   +2.29%     
==========================================
  Files          89       57      -32     
  Lines        7939     4941    -2998     
==========================================
- Hits         5726     3677    -2049     
+ Misses       2213     1264     -949     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm going to reopen that issue saying "support urllib3 > 2"

@dblock dblock merged commit e323ab2 into opensearch-project:main Dec 15, 2023
59 of 60 checks passed
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for urllib3 > v2
2 participants