-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: version number in filename for distribution. #588
Conversation
Signed-off-by: dblock <dblock@amazon.com>
37adb8c
to
7db7b95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 89 89
Lines 7922 7922
=======================================
Hits 5694 5694
Misses 2228 2228 ☔ View full report in Codecov by Sentry. |
r"__versionstr__ = \"[^\"]+\"", | ||
'__versionstr__ = "%s"' % version, | ||
r"__versionstr__: str = \"[^\"]+\"", | ||
'__versionstr__: str = "%s"' % version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't understand what any of this code is trying to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! I have no idea what this does or why 🤔
@@ -194,7 +194,7 @@ def main() -> None: | |||
if m: | |||
version = m.group(1) | |||
else: | |||
raise Exception(f"Invalid version {data}") | |||
raise Exception(f"Invalid version: {data}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get this exception? Or did the code just change the version to 0.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed the text to match another place we throw it.
…#588) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Description
Looks like we released https://pypi.org/project/opensearch-py/0.0.0/ 😢
This was caused by merging types (a type was added to
__versionstr__
but this regex was not updated).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.