-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a utf-8 header to all .py files. #557
Conversation
Signed-off-by: dblock <dblock@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 85 85
Lines 7774 7774
=======================================
Hits 5528 5528
Misses 2246 2246
|
@dblock an extremely pedantic note while reviewing changes from v2.3.2 to v2.4.2 - it looks like a couple of these encoding declarations dropped out when bcfef11 was committed ( Hopefully not a problem in itself, but perhaps an indication of some utility/process that should have left those lines intact. |
Yep, this is a problem :( |
@jayaddison I opened #613. Maybe you want to tackle it? Ideally there's a pylint rule/linter that ensures these are present everywhere, or maybe we'll need to write one. |
Possibly, yep - I'll follow along in that thread (and have asked a question about the reason for the coding declarations). |
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Description
Consistently add a utf-8 header to all .py files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.