Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps urllib3 from >=1.21.1, <2 to >=1.26.9 (#518)(Backporting to 2.3 branch) #523

Merged

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Oct 4, 2023

Signed-off-by: saimedhi saimedhi@amazon.com
(cherry picked from commit 781744c)

Description

Bumps urllib3 from >=1.21.1, <2 to >=1.26.9

Issues Resolved

Closes #516

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 781744c)
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #523 (e2ffb5b) into 2.3 (1216f66) will decrease coverage by 0.03%.
Report is 1 commits behind head on 2.3.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.3     #523      +/-   ##
==========================================
- Coverage   70.92%   70.90%   -0.03%     
==========================================
  Files          81       81              
  Lines        7732     7732              
==========================================
- Hits         5484     5482       -2     
- Misses       2248     2250       +2     
Files Coverage Δ
opensearchpy/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@saimedhi saimedhi closed this Oct 4, 2023
@saimedhi saimedhi reopened this Oct 4, 2023
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
@saimedhi
Copy link
Collaborator Author

saimedhi commented Oct 9, 2023

@VachaShah, can you please take a look.

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not removing python 3.4 support? Or is that in a different PR?

Also lets change the title of the PR to the correct versions for urllib3.

@saimedhi
Copy link
Collaborator Author

saimedhi commented Oct 9, 2023

Are we not removing python 3.4 support? Or is that in a different PR?

Also lets change the title of the PR to the correct versions for urllib3.

@VachaShah It's in another PR, and it's already merged. This PR title has the correct versions mentioned. 1.26.9 is the last version supporting Python 3.5. Please let me know if you have any more questions.

@saimedhi saimedhi requested a review from VachaShah October 9, 2023 17:50
@VachaShah VachaShah merged commit 2f57661 into opensearch-project:2.3 Oct 9, 2023
53 of 55 checks passed
@saimedhi saimedhi deleted the backport/backport-518-to-2.3 branch December 14, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants