fixes: #512 Wrong return type hint in async_scan #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavani Ravi <bhava0895@gmail.com>
bhavaniravi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 83 83
Lines 7790 7790
=======================================
Hits 5521 5521
Misses 2269 2269 |
Signed-off-by: Bhavani Ravi <bhava0895@gmail.com>
bhavaniravi
force-pushed
the
512-fix-async-scan-return-type
branch
from
30ce136 to
1f1f97f
Compare
|
Is there a way we can test this? I'm thinking if there was a unit test that would exercise this API, then |
dblock
approved these changes
Oct 3, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…pensearch-project#520) * fixes: opensearch-project#512 Wrong return type hint in async_scan Signed-off-by: Bhavani Ravi <bhava0895@gmail.com> * add: changelog Signed-off-by: Bhavani Ravi <bhava0895@gmail.com> --------- Signed-off-by: Bhavani Ravi <bhava0895@gmail.com> Signed-off-by: roma2023 <romasaparhan19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #512 Wrong return type hint in async_scan
Verified the same with opensearch API
Issues Resolved
Closes #512
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.