Backport- Fixed race condition in AWSV4SignerAuth & AWSV4SignerAsyncAuth when using refreshable credentials #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing refreshable credentials
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.3 #473 +/- ##
=======================================
Coverage 70.91% 70.92%
=======================================
Files 81 81
Lines 7730 7732 +2
=======================================
+ Hits 5482 5484 +2
Misses 2248 2248
|
dblock
approved these changes
Aug 15, 2023
|
Sorry, I missed DCO. I hope it won't create any problem. Can I release this patch version? |
|
I force-pushed a DCO fix to 2.3. Let's go a little slower and not merge things on red. |
dblock
pushed a commit
that referenced
this pull request
Aug 15, 2023
…sing refreshable credentials (#473) Co-authored-by: Logan Attwood <lattwood@users.noreply.github.com> Signed-off-by: dblock <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #470 to 2.3. Fixed race condition in AWSV4SignerAuth & AWSV4SignerAsyncAuth when using refreshable credentials
Issues Resolved
Related to #472
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.