fix : remove AttrJSONSerializer from autodoc classes to document #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happygreenbot
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 71.48% 71.48%
=======================================
Files 81 81
Lines 7667 7667
=======================================
Hits 5481 5481
Misses 2186 2186 |
happygreenbot
force-pushed
the
389-fix-make-docs
branch
from
0f7ca01 to
bc21dd4
Compare
Signed-off-by: naveen <naveenmathew0508@gmail.com>
Signed-off-by: naveen <naveenmathew0508@gmail.com>
happygreenbot
force-pushed
the
389-fix-make-docs
branch
from
bc21dd4 to
8c5825d
Compare
|
Can we add this to CI in the same PR so we don't break it in the future? |
Signed-off-by: naveen <naveenmathew0508@gmail.com>
|
@dblock Have added a test-docs-build job to CI |
dblock
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
AttributeError: AttrJSONSerializerthrown by Sphinx while building docs. AttrJSONSerializer is not an attribute of theopensearchpymodule and can be removed from autodoc.Issues Resolved
Closes #389
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.