Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security plugin support #399

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Security plugin support #399

merged 9 commits into from
Jun 27, 2023

Conversation

florianvazelle
Copy link
Collaborator

Description

Added support for the Security API.

Issues Resolved

The issue of managing roles, users... from the python client.
This issue is the subject of a feature request at #110.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #399 (87471d0) into main (db972e6) will increase coverage by 0.05%.
The diff coverage is 51.61%.

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   70.89%   70.94%   +0.05%     
==========================================
  Files          77       79       +2     
  Lines        7171     7576     +405     
==========================================
+ Hits         5084     5375     +291     
- Misses       2087     2201     +114     
Impacted Files Coverage Δ
opensearchpy/_async/plugins/security.py 51.08% <51.08%> (ø)
opensearchpy/plugins/security.py 51.08% <51.08%> (ø)
opensearchpy/_async/client/plugins.py 93.75% <100.00%> (+0.89%) ⬆️
opensearchpy/client/plugins.py 93.75% <100.00%> (+0.89%) ⬆️

... and 25 files with indirect coverage changes

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florianvazelle
Copy link
Collaborator Author

I pushed some new commits to fix my tests that never passed, because I hadn't quite understood the test suite, which isn't very clear. I added the tests in an async version.

Yes, I can add something to the USER_GUIDE, but the security API has a lot of enpoints, if I add examples for users and roles, is that enough?

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Split out security plugin tests in its own file(s). Otherwise I think this is good enough.

.ci/run-opensearch.sh Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
USER_GUIDE.md Outdated Show resolved Hide resolved
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
@dblock dblock merged commit c60c259 into opensearch-project:main Jun 27, 2023
@florianvazelle florianvazelle deleted the security-plugin branch June 28, 2023 07:43
@saimedhi
Copy link
Collaborator

Hello @florianvazelle, can you please move Security Client from plugins to clients. example: (opensearchpy/client/security.py) like in PR #439. All the security features are considered as part of core features of OS. So, kindly let me know if you are willing to make the following changes. This is crucial and had to be done before next release. Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants