-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security plugin support #399
Security plugin support #399
Conversation
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 70.89% 70.94% +0.05%
==========================================
Files 77 79 +2
Lines 7171 7576 +405
==========================================
+ Hits 5084 5375 +291
- Misses 2087 2201 +114
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can we add something to https://github.com/opensearch-project/opensearch-py/blob/main/USER_GUIDE.md#using-plugins as part of this PR?
I pushed some new commits to fix my tests that never passed, because I hadn't quite understood the test suite, which isn't very clear. I added the tests in an async version. Yes, I can add something to the USER_GUIDE, but the security API has a lot of enpoints, if I add examples for users and roles, is that enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Split out security plugin tests in its own file(s). Otherwise I think this is good enough.
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Signed-off-by: florian <florian@harfanglab.fr>
Hello @florianvazelle, can you please move Security Client from plugins to clients. example: (opensearchpy/client/security.py) like in PR #439. All the security features are considered as part of core features of OS. So, kindly let me know if you are willing to make the following changes. This is crucial and had to be done before next release. Thanks for your contributions. |
Description
Added support for the Security API.
Issues Resolved
The issue of managing roles, users... from the python client.
This issue is the subject of a feature request at #110.