Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index State Management support #398

Merged
merged 8 commits into from
Jun 28, 2023
Merged

Index State Management support #398

merged 8 commits into from
Jun 28, 2023

Conversation

florianvazelle
Copy link
Collaborator

@florianvazelle florianvazelle commented May 25, 2023 •
edited
Loading

Description

Added support for the ISM API.

Issues Resolved

The issue of managing index states from the python client.
This issue is the subject of a feature request at #284.

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #398 (6acc012) into main (c60c259) will decrease coverage by 0.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   70.88%   70.87%   -0.01%     
==========================================
  Files          79       81       +2     
  Lines        7576     7664      +88     
==========================================
+ Hits         5370     5432      +62     
- Misses       2206     2232      +26
Impacted Files Coverage Δ
opensearchpy/_async/plugins/index_management.py 42.85% <42.85%> (ø)
opensearchpy/plugins/index_management.py 80.95% <80.95%> (ø)
opensearchpy/_async/client/plugins.py 94.44% <100.00%> (+0.69%) ⬆️
opensearchpy/client/plugins.py 94.44% <100.00%> (+0.69%) ⬆️

... and 2 files with indirect coverage changes

@saimedhi
Copy link
Collaborator

Hello @florianvazelle, I notice some of Integration Tests and Lint tests are failing. Please try to fix them. Thank you.

@florianvazelle
Copy link
Collaborator Author

Hi @saimedhi, some tests seems to start opensearch without ISM plugin. Is this normal ?

https://github.com/opensearch-project/opensearch-py/actions/runs/5333494406/jobs/9664033038

@saimedhi
Copy link
Collaborator

Hi @florianvazelle, I am not completely sure but I suggest to take a look at other existing plugin tests. I have gone through Alerting plugin tests. They are passing for "integration" tests and skipped for "Integration with Unreleased Opensearch" tests. So, please take a look at those tests once. Thanks :)

dblock
dblock requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to move plugin tests into separate file(s). Please do for existing ones if this isn't the case.

test_opensearchpy/test_server/test_plugins.py Outdated Show resolved Hide resolved
@dblock
Copy link
Member

dblock commented Jun 27, 2023

Looks good, needs a rebase + user guides.

@florianvazelle
feat(plugins): add index management client plugin
6194c56 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
chore(CHANGELOG): added entry for ISM api support in changelog
843c208 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
test(plugins): use assertEqual to compare call parameters
739ed42 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
test(plugins): edit policy to support older versions of opensearch
c174706 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
test(plugins): ignore plugin tests when opensearch is unreleased
0281c32 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
test(plugins): move plugin tests into separate files
86346e9 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
test(plugins): fix import of OpenSearchTestCase
ee08b1d 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
chore(USER_GUIDE): add a index management plugin part
6acc012 
Signed-off-by: florian <florian@harfanglab.fr>
@florianvazelle
Copy link
Collaborator Author

@dblock done ! 🙂

dblock
dblock approved these changes Jun 28, 2023
View reviewed changes
USER_GUIDE.md
@@ -21,6 +21,10 @@
- [**Creating a destination**](#creating-a-destination)
- [**Getting alerts**](#getting-alerts)
- [**Acknowledge alerts**](#acknowledge-alerts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing these ** in another PR? Thanks.

@dblock dblock merged commit 2e8d5ce into opensearch-project:main Jun 28, 2023
@florianvazelle florianvazelle deleted the index-management-plugin branch June 29, 2023 07:28
@florianvazelle florianvazelle mentioned this pull request Jun 29, 2023
Merged
@dblock dblock mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@deztructor deztructor Awaiting requested review from deztructor

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianvazelle @saimedhi @dblock