Added MacOS to GitHub CI. #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 72.11% 72.11%
=======================================
Files 77 77
Lines 7190 7190
=======================================
Hits 5185 5185
Misses 2005 2005 |
dblock
force-pushed
the
macos-windows-matrix
branch
3 times, most recently
from
7abbc86 to
b163632
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
macos-windows-matrix
branch
from
b163632 to
074f8be
Compare
dblock
changed the title
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
|
I am not sure why code coverage went down, I think it's a false alarm. |
VachaShah
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Things didn't quite work out on my mac out of the box. Fixing and adding CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.