Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pyi file for point in time API #378

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

saimedhi
Copy link
Collaborator

Description

Updated pyi file for point in time API

Issues Resolved

Closes #375

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #378 (92b77bb) into main (83be2cd) will increase coverage by 1.28%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   70.72%   72.01%   +1.28%     
==========================================
  Files          77       77              
  Lines        7157     7190      +33     
==========================================
+ Hits         5062     5178     +116     
+ Misses       2095     2012      -83     

see 29 files with indirect coverage changes

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi force-pushed the fix/point_in_time_pyi_file branch from 8239d56 to 92b77bb Compare April 27, 2023 20:40
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we automate this or find a way not to get out of sync/catch that we're out of sync?

@dblock dblock merged commit 2abb8c4 into opensearch-project:main Apr 28, 2023
@saimedhi
Copy link
Collaborator Author

Can we automate this or find a way not to get out of sync/catch that we're out of sync?

@dblock, I will think about it. And also client generation might help us identifying differences or mistakes.

roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request May 9, 2023
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Jul 4, 2023
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Raman Saparkhan <romasaparhan19@gmail.com>
@jeffreylo
Copy link

@dblock any plans to cut and publish a tagged release that includes this change? v2.2.0 is the latest one and doesn’t include, unfortunately.

@dblock dblock mentioned this pull request Jul 7, 2023
@dblock
Copy link
Member

dblock commented Jul 7, 2023

We release fairly often. Add your +1 to #432.

@saimedhi saimedhi deleted the fix/point_in_time_pyi_file branch September 6, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] open_point_in_time + close_point_in_time not available on client
4 participants