Update ci workflows #318
Merged
Update ci workflows #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d run faster. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
harshavamsi
requested changes
Mar 9, 2023
.github/workflows/integration.yml
Outdated
| - { opensearch_version: 2.3.0 } | ||
| - { opensearch_version: 2.4.0 } | ||
| - { opensearch_version: 2.4.1 } | ||
| opensearch_version: [ '1.0.1', '1.1.0', '1.2.4', '1.3.7', '2.0.1', '2.1.0', '2.2.1', '2.3.0', '2.4.0', '2.5.0' ] |
There was a problem hiding this comment.
Can we also add 2.6.0 given that it was released a few days ago. Would be good to test against that as well.
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Fixed SigV4 Signing for Managed Service ([#279](https://github.com/opensearch-project/opensearch-py/pull/279)) | |||
| - Fixed SigV4 Signing for Async Requests with QueryStrings ([#272](https://github.com/opensearch-project/opensearch-py/pull/279)) | |||
| - Fixed CVE - issue 86 mentioned in opensearch-dsl-py repo ([#295](https://github.com/opensearch-project/opensearch-py/pull/295)) | |||
| - Update ci workflows ([#318](https://github.com/opensearch-project/opensearch-py/pull/318)) | |||
dblock
previously approved these changes
Mar 12, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
harshavamsi
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration with Unreleased OpenSearchjob. Before it took up to 17 min, now it takes 8.5 if cache miss (need to rebuild OpenSearch) or <2 min if cache hit (uses cached OpenSearch build).Workflow runs simplified build, so it doesn't use docker container for OpenSearch. I removed use of python client container too to further speed up the build.
Issues Resolved
Fixes #294
Note:
Integration testsworkflow unchanged, but could be accelerated the same way.See also: #309, opensearch-project/opensearch-dsl-py#105, opensearch-project/opensearch-dsl-py#92
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.