Added new OpenSearch versions and updated compatibility matrix #257
Conversation
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
|
Do you know if client v2.0 is compatible with older versions of the server, such as 1.3? |
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Added overload decorators to helpers-actions.pyi-"bulk" ([#239](https://github.com/opensearch-project/opensearch-py/pull/239)) | |||
| - Document Keberos authenticaion ([214](https://github.com/opensearch-project/opensearch-py/pull/214)) | |||
| - Add release workflows ([#240](https://github.com/opensearch-project/opensearch-py/pull/240)) | |||
| - Added new OpenSearch versions and updated compatibility matrix ([#257](https://github.com/opensearch-project/opensearch-py/pull/257)) | |||
There was a problem hiding this comment.
We should be explicit here and say something like "Compatibility with OpenSearch 2.1.0 - 2.4.1".
It should be according to https://github.com/opensearch-project/opensearch-py/blob/main/.github/workflows/integration.yml#L14. |
|
@saimedhi I would suggest adding in the older versions to the matrix that are compatible, as the presumption for users would be that the lack of a version means there exists an incompatibility. |
saimedhi
force-pushed
the
fix/compatibility_matrix
branch
from
f091590 to
06d9334
Compare
COMPATIBILITY.md
Outdated
|
|
||
| | Client Version | OpenSearch Version | Notes | | ||
| | --- | --- | --- | | ||
| | 1.0.0 | 1.0.0-1.0.1, 1.2.1-1.2.4 | | |
There was a problem hiding this comment.
It might be a typo in the previous markdown, 1.1.0 client version was released with being compatible from OpenSearch versions 1.3.0. Can you please update that?
There was a problem hiding this comment.
@VachaShah Made the changes as suggested.
saimedhi
force-pushed
the
fix/compatibility_matrix
branch
2 times, most recently
from
12d4582 to
bd888e4
Compare
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
fix/compatibility_matrix
branch
from
bd888e4 to
7faa02f
Compare
saimedhi
requested review from
VachaShah and
harshavamsi
and removed request for
VachaShah
Signed-off-by: saimedhi saimedhi@amazon.com
Description
Added new OpenSearch versions and updated compatibility matrix
Issues Resolved
Closes #252
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.