Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bulk action in helpers #239

Merged

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Nov 9, 2022

Signed-off-by: saimedhi saimedhi@amazon.com

Description

Updated bulk action in helpers

Issues Resolved

Closes #154

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can add tests for typings? Is there such a thing?

@saimedhi
Copy link
Collaborator Author

saimedhi commented Nov 9, 2022

I will try that. @harshavamsi can you please take a look.

@saimedhi saimedhi force-pushed the fix/helpers/actions.pyi/bulk branch from f8dbe3b to 66e2fe2 Compare November 9, 2022 19:24
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi force-pushed the fix/helpers/actions.pyi/bulk branch from 66e2fe2 to e02edc6 Compare November 9, 2022 19:28
@dblock dblock merged commit dea10c8 into opensearch-project:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] helpers.bulk action is incorrectly typed
3 participants