Include parsed error info in TransportError in async connections

[gg-kialo]

Fixes #225

Signed-off-by: Gordon Govan gg@kialo.com

Description

Parses the error into the info field of TransportExceptions in the async connection to match the behaviour of the sync connection.

Issues Resolved

Closes #225

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

How does this include the error info? I see you add content-type.

Either way needs a test, please.

[dblock]

Add a link here to the PR

([#226](https://github.com/opensearch-project/opensearch-py/pull/226))

[gg-kialo]

Any hints as to where I could add a test? https://github.com/opensearch-project/opensearch-py/blob/main/test_opensearchpy/test_async/test_connection.py would seem like a good choice, but those tests are using httpbin.org, which doesn't provide an endpoint that returns both a error code and a json body.

[dblock]

Any hints as to where I could add a test? https://github.com/opensearch-project/opensearch-py/blob/main/test_opensearchpy/test_async/test_connection.py would seem like a good choice, but those tests are using httpbin.org, which doesn't provide an endpoint that returns both a error code and a json body.

I generally have a very dumb approach to this, so a change in opensearchpy/_async/http_aiohttp.py should be tested in .../_async/test_http_aiohttp.py.

[gg-kialo]

@dblock I've added a test and resolved the conflicts.

[dblock]

One more. I see places (e.g.

opensearch-py/opensearchpy/transport.py

Line 420 in 2abb8c4

data, headers_response.get("content-type")

) where we do lowercase content-type. Is the map not case-sensitive? Is it always Content-Type?

If so, let's lowercase content-type in the get just like elsewhere in the code and leave Content-Type in the test capitalized to show it works?

[codecov-commenter]

Codecov Report

Merging #226 (caab1c3) into main (2abb8c4) will increase coverage by 0.66%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   71.44%   72.11%   +0.66%     
==========================================
  Files          77       77              
  Lines        7190     7190              
==========================================
+ Hits         5137     5185      +48     
+ Misses       2053     2005      -48     

Impacted Files	Coverage Δ
opensearchpy/_async/http_aiohttp.py	82.81% <100.00%> (+3.12%)	⬆️

... and 15 files with indirect coverage changes

[gg-kialo]

@dblock, yes, headers is a CIMultiDictProxy (where CI is case-insensitive).