Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added pool_maxsize in RequestsHttpConnection #216

Merged
merged 2 commits into from
Dec 1, 2022
Merged

feat: Added pool_maxsize in RequestsHttpConnection #216

merged 2 commits into from
Dec 1, 2022

Conversation

Neckbuster
Copy link
Contributor

Description

Provides custom connection pool size for RequestHttpConnection transport class

Issues Resolved

Closes proposal/issue #203

@Neckbuster Neckbuster requested review from a team, axeoman and deztructor as code owners October 6, 2022 17:41
@dblock
Copy link
Member

dblock commented Oct 6, 2022

Would it make sense to provide an http_adapter_options structure that wraps all the other options available in HTTPAdapter?

@harshavamsi
Copy link
Collaborator

@Neckbuster the implementation looks fine to me. Can you sign off your commit with -s to allow DCO to pass? Also, can you add a unit test to ensure this works against our tests?

dblock
dblock requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally missed the updates to this, apologies. Let's add some documentation to https://github.com/opensearch-project/opensearch-py/blob/main/GETTING_STARTED.md for it before merging?

@Neckbuster Neckbuster force-pushed the main branch 3 times, most recently from fe9604a to 49d2c91 Compare November 24, 2022 17:20
@Neckbuster Neckbuster requested a review from dblock November 24, 2022 17:21
@niketsingh007 @Neckbuster
feat: Added pool_maxsize for RequestsHttpConnection
de5dd41 
Signed-off-by: Niket Singh <singhnik82@gmail.com>
@Neckbuster
Copy link
Contributor Author

Totally missed the updates to this, apologies. Let's add some documentation to https://github.com/opensearch-project/opensearch-py/blob/main/GETTING_STARTED.md for it before merging?

Thanks @dblock Have updated documentation info, please have a look.

@dblock
Copy link
Member

dblock commented Nov 28, 2022

@harshavamsi @VachaShah 2nd pls? Let's merge this?

@harshavamsi harshavamsi merged commit b6b35f4 into opensearch-project:main Dec 1, 2022
@harshavamsi harshavamsi mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@deztructor deztructor Awaiting requested review from deztructor

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neckbuster @dblock @harshavamsi @niketsingh007