Fix point in time rest api #191

Arpit-Bandejiya · 2022-08-19T09:58:02Z

Signed-off-by: Arpit Bandejiya abandeji@amazon.com

Description

Changes for point in time API

Related issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearchpy/_async/client/__init__.py

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

opensearchpy/_async/client/__init__.py

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Bukhtawar

Is there a way we could add tests for the same?

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya · 2022-08-23T04:38:59Z

Is there a way we could add tests for the same?

Have added the tests. Thanks @Bukhtawar

bharath-techie · 2022-08-24T12:31:47Z

test_opensearchpy/test_client/test_point_in_time.py

+        self.assert_url_called("POST", "/test-index/_search/point_in_time")
+
+    def test_delete_one_point_in_time(self):
+        self.client.delete_point_in_time(body={})


we should not call delete with empty body . its delete all or delete with list of pit ids in empty.

Sure, have updated it in the new revision. Thanks!

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya · 2022-10-06T08:04:54Z

noxfile.py

@@ -48,7 +48,7 @@ def format(session):
    session.install("black", "isort")

    session.run("isort", "--profile=black", *SOURCE_FILES)
-    session.run("black", "--target-version=py27", *SOURCE_FILES)
+    session.run("black", "--target-version=py33", *SOURCE_FILES)


Fix for running lint formatter in nox, the py27 is not supported any more. We have update it in other places in the same file but this was left.

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya · 2022-10-19T12:31:26Z

@VachaShah @axeoman please have a look

Arpit-Bandejiya · 2022-10-26T06:12:02Z

@dblock please have a look. Thanks!

dblock

This is a new API we never shipped, right? Meaning we're not breaking any backwards compatibility here?

Document this in https://github.com/opensearch-project/opensearch-py/blob/main/GETTING_STARTED.md too please. Also #227

test_opensearchpy/test_client/test_point_in_time.py

dhruv16dhr · 2022-10-27T06:44:08Z

USER_GUIDE.md

+print('\n Point in time ID:')
+print(pit_id)
+
+# To list all point in time which are plive in the cluster


nit: *alive

dhruv16dhr · 2022-10-27T06:46:03Z

USER_GUIDE.md


+# delete point in time
+body = {


nit: should we have better variable naming, applies to pit_id as well

USER_GUIDE.md

dhruv16dhr · 2022-10-27T07:07:59Z

USER_GUIDE.md

@@ -119,7 +120,39 @@ response = client.indices.delete(
 print('\nDeleting index:')
 print(response)
 ```
+## Making API Calls
+
+### Point in Time API calls


Should we give a brief about Point In Time here?

Will update it with the official documentation link later.

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya · 2022-10-27T16:11:25Z

@dblock please take a look. Thanks!

dblock

LGTM, care to rebase?

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

dblock · 2022-11-01T12:35:16Z

@Arpit-Bandejiya Needs a CHANGELOG entry as well, thx

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

VachaShah

Thank you @Arpit-Bandejiya! This LGTM

Arpit-Bandejiya · 2022-11-02T04:11:31Z

Please merge the PR @opensearch-project/clients

bharath-techie reviewed Aug 19, 2022

View reviewed changes

opensearchpy/_async/client/__init__.py Outdated Show resolved Hide resolved

bharath-techie reviewed Aug 19, 2022

View reviewed changes

opensearchpy/_async/client/__init__.py Show resolved Hide resolved

bharath-techie reviewed Aug 19, 2022

View reviewed changes

opensearchpy/_async/client/__init__.py Outdated Show resolved Hide resolved

Add change for point in time

6709579

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya force-pushed the pit branch from 0c2d621 to 6709579 Compare August 22, 2022 05:14

dhruv16dhr reviewed Aug 22, 2022

View reviewed changes

opensearchpy/_async/client/__init__.py Outdated Show resolved Hide resolved

dhruv16dhr reviewed Aug 22, 2022

View reviewed changes

opensearchpy/_async/client/__init__.py Outdated Show resolved Hide resolved

resolve minor comments

216ba33

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya marked this pull request as ready for review August 22, 2022 08:04

Arpit-Bandejiya requested review from a team, axeoman and deztructor as code owners August 22, 2022 08:04

Bukhtawar reviewed Aug 22, 2022

View reviewed changes

Add Unit tests

fdd2e9d

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

dhruv16dhr previously approved these changes Aug 23, 2022

View reviewed changes

bharath-techie reviewed Aug 24, 2022

View reviewed changes

minor changes

fb8460c

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya dismissed dhruv16dhr’s stale review via fb8460c September 5, 2022 13:13

minor edits in API calls

faefc8e

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya commented Oct 6, 2022

View reviewed changes

Fixing lint errors

add6177

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya force-pushed the pit branch from f2ff1b1 to add6177 Compare October 17, 2022 04:37

bharath-techie previously approved these changes Oct 19, 2022

View reviewed changes

dblock requested changes Oct 26, 2022

View reviewed changes

test_opensearchpy/test_client/test_point_in_time.py Outdated Show resolved Hide resolved

Arpit-Bandejiya dismissed bharath-techie’s stale review via 99583e8 October 27, 2022 06:02

Arpit-Bandejiya requested review from VachaShah and harshavamsi as code owners October 27, 2022 06:02

Arpit-Bandejiya force-pushed the pit branch from 99583e8 to ac48aae Compare October 27, 2022 06:04

Arpit-Bandejiya requested a review from dblock October 27, 2022 06:06

dhruv16dhr reviewed Oct 27, 2022

View reviewed changes

USER_GUIDE.md Outdated

print('\n Point in time ID:')

print(pit_id)

# To list all point in time which are plive in the cluster

Copy link

dhruv16dhr Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: *alive

dhruv16dhr reviewed Oct 27, 2022

View reviewed changes

USER_GUIDE.md Outdated

# delete point in time

body = {

Copy link

dhruv16dhr Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we have better variable naming, applies to pit_id as well

dhruv16dhr reviewed Oct 27, 2022

View reviewed changes

USER_GUIDE.md Outdated Show resolved Hide resolved

dhruv16dhr reviewed Oct 27, 2022

View reviewed changes

Arpit-Bandejiya added 2 commits October 27, 2022 15:15

minor nit fix

07daaf4

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

minor nit fix

c9af990

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

dblock previously approved these changes Nov 1, 2022

View reviewed changes

dblock requested a review from Bukhtawar November 1, 2022 11:30

Resolved conflicts

2a71d40

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya dismissed dblock’s stale review via 2a71d40 November 1, 2022 11:43

Added license in test file

226c1bc

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Add ChangeLog

55d9d0c

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

Arpit-Bandejiya requested review from dblock and dhruv16dhr and removed request for Bukhtawar and dblock November 1, 2022 15:45

dblock approved these changes Nov 1, 2022

View reviewed changes

dblock requested review from bharath-techie and removed request for dhruv16dhr November 1, 2022 16:02

dhruv16dhr approved these changes Nov 1, 2022

View reviewed changes

VachaShah approved these changes Nov 1, 2022

View reviewed changes

VachaShah merged commit 8ece008 into opensearch-project:main Nov 2, 2022

wbeckler mentioned this pull request Nov 30, 2022

Release 2.0.1 has new features that would merit a minor version bump #248

Closed

dblock mentioned this pull request Apr 25, 2023

Adds point in time APIs opensearch-project/opensearch-java#461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix point in time rest api #191

Fix point in time rest api #191

Arpit-Bandejiya commented Aug 19, 2022 •

edited

Loading

Bukhtawar left a comment

Arpit-Bandejiya commented Aug 23, 2022

bharath-techie Aug 24, 2022

Arpit-Bandejiya Oct 1, 2022

Arpit-Bandejiya Oct 6, 2022

Arpit-Bandejiya commented Oct 19, 2022

Arpit-Bandejiya commented Oct 26, 2022

dblock left a comment •

edited

Loading

dhruv16dhr Oct 27, 2022

dhruv16dhr Oct 27, 2022

dhruv16dhr Oct 27, 2022

Arpit-Bandejiya Oct 27, 2022 •

edited

Loading

Arpit-Bandejiya commented Oct 27, 2022

dblock left a comment

dblock commented Nov 1, 2022

VachaShah left a comment

Arpit-Bandejiya commented Nov 2, 2022

Fix point in time rest api #191

Fix point in time rest api #191

Conversation

Arpit-Bandejiya commented Aug 19, 2022 • edited Loading

Description

Related issue

Bukhtawar left a comment

Choose a reason for hiding this comment

Arpit-Bandejiya commented Aug 23, 2022

bharath-techie Aug 24, 2022

Choose a reason for hiding this comment

Arpit-Bandejiya Oct 1, 2022

Choose a reason for hiding this comment

Arpit-Bandejiya Oct 6, 2022

Choose a reason for hiding this comment

Arpit-Bandejiya commented Oct 19, 2022

Arpit-Bandejiya commented Oct 26, 2022

dblock left a comment • edited Loading

Choose a reason for hiding this comment

dhruv16dhr Oct 27, 2022

Choose a reason for hiding this comment

dhruv16dhr Oct 27, 2022

Choose a reason for hiding this comment

dhruv16dhr Oct 27, 2022

Choose a reason for hiding this comment

Arpit-Bandejiya Oct 27, 2022 • edited Loading

Choose a reason for hiding this comment

Arpit-Bandejiya commented Oct 27, 2022

dblock left a comment

Choose a reason for hiding this comment

dblock commented Nov 1, 2022

VachaShah left a comment

Choose a reason for hiding this comment

Arpit-Bandejiya commented Nov 2, 2022

Arpit-Bandejiya commented Aug 19, 2022 •

edited

Loading

dblock left a comment •

edited

Loading

Arpit-Bandejiya Oct 27, 2022 •

edited

Loading