Skip to content

Commit

Permalink
Update dev guide, lock aiohttp to a version that works. (#828)
Browse files Browse the repository at this point in the history
* Update developer guide with test setup instructions using OpenSearch 2.12+.

Signed-off-by: dblock <dblock@amazon.com>

* Lock down aiohttp to <= 3.10.5.

Signed-off-by: dblock <dblock@amazon.com>

* Exclude failing integ test.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
  • Loading branch information
dblock authored Sep 25, 2024
1 parent a24b9f3 commit 45d8172
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions DEVELOPER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ docker pull opensearchproject/opensearch:latest
Integration tests will auto-start the docker image. To start it manually:

```
docker run -d -p 9200:9200 -p 9600:9600 -e "discovery.type=single-node" opensearchproject/opensearch:latest
docker run -d -p 9200:9200 -p 9600:9600 -e OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! -e "discovery.type=single-node" opensearchproject/opensearch:latest
```

## Running Tests
Expand All @@ -54,7 +54,7 @@ python setup.py test
To run tests in a specific test file.

```
python setup.py test -s test_opensearchpy/test_connection.py
python setup.py test -s test_opensearchpy/test_connection/test_base_connection.py
```

If you want to auto-start one, the following will start a new instance and run tests against the latest version of OpenSearch.
Expand Down
2 changes: 1 addition & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ black>=24.3.0
twine

# Requirements for testing [async] extra
aiohttp>=3.9.4, <4
aiohttp>=3.9.4, <=3.10.5
pytest-asyncio<=0.24.0
unasync
1 change: 1 addition & 0 deletions test_opensearchpy/test_server/test_rest_api_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/search/340_doc_values_field[0]",
"OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/search/340_doc_values_field[1]",
"OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/search/aggregation/20_terms[4]",
"OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/search/aggregation/410_nested_aggs[0]",
"OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/tasks/list/10_basic[0]",
}

Expand Down

0 comments on commit 45d8172

Please sign in to comment.