Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added download link to the notebook #73

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

dhrubo-os
Copy link
Collaborator

Signed-off-by: Dhrubo Saha dhrubo@amazon.com

Description

[1. Added download like to the notebooks
2. Modified listing page of the notebooks
]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os requested a review from mingshl as a code owner February 6, 2023 23:02
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os merged commit cd41a44 into opensearch-project:main Feb 6, 2023
@dhrubo-os dhrubo-os deleted the notebook_modification branch February 6, 2023 23:47
gaiksaya pushed a commit to gaiksaya/opensearch-py-ml that referenced this pull request Feb 10, 2023
* added download link to the notebook

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* updated noxfile

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing nox issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* revert noxfile

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants