refactoring upload_api + added integration test + added load model ap… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i support Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn
approved these changes
Dec 19, 2022
mingshl
suggested changes
Dec 19, 2022
There was a problem hiding this comment.
"After generated a model zip file, the users will need to describe model configuration in a ml-commons_model_config.json file. The `make_model_config_json` function in sentencetransformermodel class will parse the config file from hugging-face config.son file. If users would like to use a different config than the pre-trained sentence transformer, `make_model_config_json` function provide arguuments to change the configuration content and generated a ml-commons_model_config.json file. Plese visit the [SentenceTransformerModel.make_model_config_json](https://opensearch-project.github.io/opensearch-py-ml/reference/api/sentence_transformer.html#opensearch_py_ml.sentence_transformer_model.SentenceTransformerModel.make_model_config_json) for API Reference . \n",
"\n",
can you please replace the hyperlinks? It looks like the url changed and no longer pointed to the designated page. in this function , use this url instead:
[(https://opensearch-project.github.io/opensearch-py-ml/reference/api/sentence_transformer.make_model_config_json.html)]
would you please check all the hyperlink for the api references in demo notebook and change accordingly?
mingshl
approved these changes
Dec 19, 2022
gaiksaya
pushed a commit
to gaiksaya/opensearch-py-ml
that referenced
this pull request
Feb 10, 2023
…i support (opensearch-project#54) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…i support
Signed-off-by: Dhrubo Saha dhrubo@amazon.com
Description
[1. refactoring ml commons apis integration
2. added integration test
3. added load model api connectivity
4. CVE issue solved]
Issues Resolved
[49]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.