-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding documentation for model group id #176
Conversation
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 90.79% 90.80% +0.01%
==========================================
Files 37 37
Lines 4042 4047 +5
==========================================
+ Hits 3670 3675 +5
Misses 372 372
|
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
There will be some changes to create model group automatically in the backend when first model version is registered. We might need to reflect those changes to the documentation including this PR. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-176-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03199fbc7a3a055b9a85971634ee5c94e1354c32
# Push it to GitHub
git push --set-upstream origin backport/backport-176-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* adding documentation for model group id Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * fixing release number Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * resolving commits Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * fixing lint Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding changelog Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
* adding documentation for model group id * fixing release number * resolving commits * fixing lint * adding changelog --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
Description
[From 2.8 we need to provide model group id during registering the model. So we needed to reflect that change. Also from 2.7 we are supporting to register pre-trained models. So I added detailed explanation in the notebook for better customer experience. ]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.