Skip to content

Conversation

@PauiC
Copy link

@PauiC PauiC commented Oct 30, 2025

Description

Integrate skill tool

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am
Copy link

can we put some test result for the new tool too?

@PauiC
Copy link
Author

PauiC commented Oct 31, 2025

Here is an example of using the Amazon Q CLI to call a tool via the MCP server.
image

Copy link
Collaborator

@rithin-pullela-aws rithin-pullela-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Over all it looks good, added 2 small comments.

Can we add some Unit tests for this?

@rithin-pullela-aws
Copy link
Collaborator

rithin-pullela-aws commented Nov 11, 2025

Hi @PauiC , can you rebase your changes with the latest main?

Also please resolve DCO issue in the CI

@PauiC PauiC force-pushed the integrate-skill-tool branch from a1d29a2 to d6c6e39 Compare November 13, 2025 03:22
Copy link
Collaborator

@rithin-pullela-aws rithin-pullela-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @PauiC !

Can you please rebase your changes with the current main and test and push?

One major change in the latest release is the usage of async openserach client. You can take a look at functions in helper.py to understand how to get the client and use it

Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>

# Conflicts:
#	tests/tools/test_tool_filters.py
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
@PauiC PauiC force-pushed the integrate-skill-tool branch from b1b8738 to b9740c2 Compare November 20, 2025 02:44
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants