-
Notifications
You must be signed in to change notification settings - Fork 49
[FEATURE] Integrate skill tool #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
can we put some test result for the new tool too? |
rithin-pullela-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Over all it looks good, added 2 small comments.
Can we add some Unit tests for this?
|
Hi @PauiC , can you rebase your changes with the latest main? Also please resolve DCO issue in the CI |
a1d29a2 to
d6c6e39
Compare
rithin-pullela-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @PauiC !
Can you please rebase your changes with the current main and test and push?
One major change in the latest release is the usage of async openserach client. You can take a look at functions in helper.py to understand how to get the client and use it
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
b1b8738 to
b9740c2
Compare
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>

Description
Integrate skill tool
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.