Fix wrong documentation for file serach.md regarding search_after param
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajh0509
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
Signed-off-by: pajh0509 <pajh0509@gmail.com>
pajh0509
force-pushed
the
update-search-md
branch
from
cfd1988
to
c1a024a
Compare
pajh0509
changed the title
serach.md regarding search_after param
dblock
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Thanks. It would be great if this "pagination" example actually did pagination, meaning that it iterated through all pages and output all the results in a for loop.
aaaand, if you feel really inspired, we need working samples ala https://github.com/opensearch-project/opensearch-py/tree/main/samples here to avoid this kind of mistakes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was following instructions in
search.mdin order to usesearch()functions, especially withsearch_afterparam. And found out given example doesn't work. I made some changes so that people can make use of the code snippet insearch.mdwithout logical error.Issues Resolved
No issue resolved
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.