Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: test. #972

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix: test. #972

merged 1 commit into from
May 7, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented May 7, 2024

Description

CI broke in two overlapping commits merged on top of each other.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@reta
Copy link
Collaborator

reta commented May 7, 2024

Thanks @dblock !

@reta reta merged commit 73c1f5b into opensearch-project:main May 7, 2024
54 checks passed
@dblock dblock deleted the fix-test branch May 7, 2024 11:54
VachaShah pushed a commit to VachaShah/opensearch-java that referenced this pull request May 7, 2024
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah
Copy link
Collaborator

Backported this along with original change in #974

reta pushed a commit that referenced this pull request May 7, 2024
…974)

* Fixing composite aggregations with correct parameters (#967)

* Fixing composite aggregations with correct parameters

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding guides, samples and fixing tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Fix: test. (#972)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants