Fix integer overflow for remaining index stats #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda and
saratvemulapalli
as code owners
reta
previously approved these changes
Feb 23, 2024
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
|
@reta I added changelog and merged the latest changes from main. |
reta
approved these changes
Feb 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Fix integer overflow for remaining index stats Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding changelog Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 0c88a6a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Fix integer overflow for remaining index stats * Adding changelog --------- (cherry picked from commit 0c88a6a) Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some values in index stats still have an int which can overflow as reported in #875. Fixing in this PR. A similar fix was done some time back for some stats: #489.
I also skimmed through other stats to verify that the variables related to bytes are converted to long.
Issues Resolved
Fixes #875
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.