-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add Support for Hybrid Query Type #857
Conversation
@vibrantvarun Can you please take a look at the failures in integration tests? |
Hey @VachaShah I forgot to add a check to run hybrid query integ test >=2.10 OS version. Now what are my options to not make 2.x and main divergent and put the check in main as well as 2.x? cc: @reta |
We do have cases when version of OpenSearch matters [1], fe you may use
[1] |
@reta so shall I add the assume true in the backport PR (2.x) or create a new PR on main? |
I think |
I have a suggestion, we can merge the fix on main with a new PR and then manually create a backport PR with 2 commits and merge on 2.x |
That makes sense! Thanks @reta! |
@vibrantvarun Can you resolve the conflicts? |
* Add Support for Hybrid Query Type Signed-off-by: Varun Jain <varunudr@amazon.com> * Add samples, guide and integ tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing wildcard imports Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding import Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit 821dae6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Vacha Shah <vachshah@amazon.com>
60f80d8
to
4e8b97a
Compare
Backport 821dae6 from #850.