Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Support for Hybrid Query Type #857

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 821dae6 from #850.

@VachaShah
Copy link
Collaborator

@vibrantvarun Can you please take a look at the failures in integration tests?

@vibrantvarun
Copy link
Member

Hey @VachaShah I forgot to add a check to run hybrid query integ test >=2.10 OS version. Now what are my options to not make 2.x and main divergent and put the check in main as well as 2.x?

cc: @reta

@reta
Copy link
Collaborator

reta commented Feb 21, 2024

Hey @VachaShah I forgot to add a check to run hybrid query integ test >=2.10 OS version. Now what are my options to not make 2.x and main divergent and put the check in main as well as 2.x?

We do have cases when version of OpenSearch matters [1], fe you may use assumeTrue to filter out the tests which are not relevant:

        assumeTrue(
            "The PIT is supported in OpenSearch 2.4.0 and later",
            Version.fromString(version).onOrAfter(Version.fromString("2.4.0"))
        );

[1]

@vibrantvarun
Copy link
Member

@reta so shall I add the assume true in the backport PR (2.x) or create a new PR on main?

@reta
Copy link
Collaborator

reta commented Feb 21, 2024

@reta so shall I add the assume true in the backport PR (2.x) or create a new PR on main?

I think main is fine, we could limit the change to 2.x only, @VachaShah does it make sense? thank you

@vibrantvarun
Copy link
Member

vibrantvarun commented Feb 21, 2024

I have a suggestion,

we can merge the fix on main with a new PR and then manually create a backport PR with 2 commits and merge on 2.x
cc: @VachaShah

@VachaShah
Copy link
Collaborator

@reta so shall I add the assume true in the backport PR (2.x) or create a new PR on main?

I think main is fine, we could limit the change to 2.x only, @VachaShah does it make sense? thank you

That makes sense! Thanks @reta!

@VachaShah
Copy link
Collaborator

@vibrantvarun Can you resolve the conflicts?

github-actions bot and others added 2 commits February 21, 2024 19:48
* Add Support for Hybrid Query Type

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Add samples, guide and integ tests

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Removing wildcard imports

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Adding import

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Adding import

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
(cherry picked from commit 821dae6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah merged commit cada0fc into 2.x Feb 21, 2024
80 checks passed
@github-actions github-actions bot deleted the backport/backport-850-to-2.x branch February 21, 2024 19:57
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants