Add support for Flat Objects #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bfindlay
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Bfindlay
force-pushed
the
bfindlay/flat-objekts
branch
from
1b37dbb
to
82b5035
Compare
Signed-off-by: bfindlay <bfindlay@acm.org>
Yeah, was just a naming issue as OpenSearch is using FlatObject https://github.com/opensearch-project/OpenSearch/blob/60c46f3a6c33b1c1074f161b629927e5d60917c0/server/src/main/java/org/opensearch/index/mapper/FlatObjectFieldMapper.java#L184 |
reta
previously approved these changes
Nov 20, 2023
reta
reviewed
Nov 20, 2023
...client/src/main/java/org/opensearch/client/opensearch/_types/mapping/FlatObjectProperty.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Nov 20, 2023
...client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractIndicesClientIT.java
Show resolved
Hide resolved
|
@Bfindlay Consider writing a complete working sample with the changes in https://github.com/opensearch-project/opensearch-java/tree/main/samples. |
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
reta
reviewed
Nov 21, 2023
...client/src/main/java/org/opensearch/client/opensearch/_types/mapping/FlatObjectProperty.java
Show resolved
Hide resolved
reta
approved these changes
Nov 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* add flat object support Signed-off-by: bfindlay <bfindlay@acm.org> * add flat object support Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog Signed-off-by: bfindlay <bfindlay@acm.org> * update flatobject and user guides Signed-off-by: bfindlay <bfindlay@acm.org> * fix typo Signed-off-by: bfindlay <bfindlay@acm.org> * remove unused comments Signed-off-by: bfindlay <bfindlay@acm.org> --------- Signed-off-by: bfindlay <bfindlay@acm.org> (cherry picked from commit a4dc4f0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 21, 2023
* add flat object support * add flat object support * update changelog * update flatobject and user guides * fix typo * remove unused comments --------- (cherry picked from commit a4dc4f0) Signed-off-by: bfindlay <bfindlay@acm.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
"Flattened" is the elasticsearch variant and not recognised in opensearch. This PR removes the use of "flattened" and adds the "FlatObject" property type.
This is only supported from OpenSearch version 2.7.0 onwards
https://opensearch.org/docs/latest/field-types/supported-field-types/flat-object/
Issues Resolved
#720
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.