Exclude Apache HttpClient5 transitive dependencies on Apache HttpCore5 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
cwperks
approved these changes
Jul 7, 2023
szczepanczykd
approved these changes
Jul 7, 2023
owaiskazi19
reviewed
Jul 7, 2023
| @@ -151,7 +151,9 @@ dependencies { | |||
| compileOnly("org.opensearch.client", "opensearch-rest-client", opensearchVersion) | |||
| testImplementation("org.opensearch.test", "framework", opensearchVersion) | |||
|
|
|||
| api("org.apache.httpcomponents.client5:httpclient5:5.2.1") | |||
| api("org.apache.httpcomponents.client5:httpclient5:5.2.1") { | |||
| exclude(group = "org.apache.httpcomponents.core5") | |||
There was a problem hiding this comment.
@reta if we are excluding the dependency on core5 here. Do we still need to exclude it on the SDK repo?
There was a problem hiding this comment.
@owaiskazi19 yes, because for SDK, there are indeed 2 clients (rest & this one), both importing Client5 / Core5, the 3.0.0 release line (opensearch-java) has no runtime dependencies on OpenSearch core. When SDK picks just one client - issue will be gone.
owaiskazi19
approved these changes
Jul 7, 2023
dblock
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reasons, Gradle still tries to bring transitive dependencies on Apache HttpCore5 (from Apache HttpClient5 ) nonetheless we explicitly provide those.
Excluding those to get:
Thanks a lot to @cwperks for highlighting that
Issues Resolved
Related to opensearch-project/opensearch-sdk-java#857
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.