Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add several missing fields in MultisearchBody.Builder (#506) #516

Merged

Conversation

Mstrutov
Copy link
Contributor

@Mstrutov Mstrutov commented Jun 5, 2023

Description

Now we can use minScore, postFilter, searchAfter, sort and trackScores in Multisearch Request.

Issues Resolved

Closes #506

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
@Mstrutov Mstrutov force-pushed the fix/add-fields-to-msearch-body-506 branch from 56d1d7b to 78869cb Compare June 5, 2023 11:42
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Mstrutov!

@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Jun 5, 2023
@VachaShah VachaShah merged commit 14303de into opensearch-project:main Jun 5, 2023
reta pushed a commit to reta/opensearch-java that referenced this pull request Jun 6, 2023
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

---------

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
reta pushed a commit to reta/opensearch-java that referenced this pull request Jun 6, 2023
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

---------

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
reta pushed a commit to reta/opensearch-java that referenced this pull request Jun 6, 2023
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>

---------

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit that referenced this pull request Jun 6, 2023
…) (#519)

* fix: add several missing fields in MultisearchBody.Builder (#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody



* update CHANGELOG.md



---------

Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Mstrutov <41866740+Mstrutov@users.noreply.github.com>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing options in Multisearch request item body
3 participants