Update TextEmbeddingProcessor.java #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change type Signed-off-by: leeeeeeeeeeehc <ehc0825@naver.com>
ehc0825
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
|
Thanks, can you please explain why? |
|
@ehc0825 Could you please add an entry to the |
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
previously approved these changes
Sep 30, 2024
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Update TextEmbeddingProcessor.java change type Signed-off-by: leeeeeeeeeeehc <ehc0825@naver.com> * Add changelog entry Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: leeeeeeeeeeehc <ehc0825@naver.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 28e8b89) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Xtansia
added a commit
that referenced
this pull request
Sep 30, 2024
* Update TextEmbeddingProcessor.java change type * Add changelog entry --------- (cherry picked from commit 28e8b89) Signed-off-by: leeeeeeeeeeehc <ehc0825@naver.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change type
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.