Default normalizer deserialization to custom type when unspecified (#…

…1111)

* Default normalizer deserialization to custom type when unspecified

Signed-off-by: beniamin.jedrychowsk <beniamin.jedrychowski@transatel.com>

* fix style

Signed-off-by: beniamin.jedrychowsk <beniamin.jedrychowski@transatel.com>

* Update CHANGELOG.md

fixed changelog formatting

Co-authored-by: Thomas Farr <xtansia@xtansia.com>
Signed-off-by: Beniamin Jędrychowski <beniamin.jedrychowski@transatel.com>

---------

Signed-off-by: beniamin.jedrychowsk <beniamin.jedrychowski@transatel.com>
Signed-off-by: Beniamin Jędrychowski <beniamin.jedrychowski@transatel.com>
Co-authored-by: Thomas Farr <xtansia@xtansia.com>
(cherry picked from commit 905aa34)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

CHANGELOG.md

@@ -14,6 +14,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ### Removed
 
 ### Fixed
+- Fixed error when deserializing a normalizer without 'type' ([#1111](https://github.com/opensearch-project/opensearch-java/pull/1111))
 
 ### Security
 

java-client/src/main/java/org/opensearch/client/opensearch/_types/analysis/Normalizer.java

@@ -186,7 +186,7 @@ protected static void setupNormalizerDeserializer(ObjectDeserializer<Builder> op
         op.add(Builder::custom, CustomNormalizer._DESERIALIZER, "custom");
         op.add(Builder::lowercase, LowercaseNormalizer._DESERIALIZER, "lowercase");
 
-        op.setTypeProperty("type", null);
+        op.setTypeProperty("type", Kind.Custom.jsonValue());
 
     }
 

java-client/src/test/java/org/opensearch/client/opensearch/_types/analysis/NormalizerDeserializerTest.java

@@ -0,0 +1,24 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ */
+
+package org.opensearch.client.opensearch._types.analysis;
+
+import org.junit.Test;
+import org.opensearch.client.opensearch.model.ModelTestCase;
+
+public class NormalizerDeserializerTest extends ModelTestCase {
+
+    @Test
+    public void deserializesTypelessCustomAnalyzer() {
+        String json = "{\n" + "          \"filter\": \"lowercase\"\n" + "      }";
+
+        Normalizer normalizer = fromJson(json, Normalizer._DESERIALIZER);
+        assertTrue(normalizer.isCustom());
+        assertEquals("lowercase", normalizer.custom().filter().get(0));
+    }
+}