Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to go 1.21 version and jsondiff to 0.5.1 #509

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

VachaShah
Copy link
Collaborator

Description

Coming from #480, jsondiff upgrade needs go 1.21+.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.29%. Comparing base (f3ad333) to head (1a1fa4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   57.29%   57.29%           
=======================================
  Files         315      315           
  Lines        9823     9823           
=======================================
  Hits         5628     5628           
  Misses       2902     2902           
  Partials     1293     1293           
Flag Coverage Δ
integration 50.83% <ø> (ø)
unit 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Jakob3xD
Jakob3xD previously approved these changes Apr 5, 2024
Copy link
Collaborator

@Jakob3xD Jakob3xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Should be okay now as golang 1.22 is released and 1.20 is therefore no longer "supported".

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah
Copy link
Collaborator Author

@Jakob3xD Can I get an approval again? Had to rebase due to conflicts in CHANGELOG. Thank you!

@VachaShah VachaShah requested a review from Jakob3xD April 5, 2024 18:01
@Jakob3xD Jakob3xD merged commit 609bfef into opensearch-project:main Apr 5, 2024
53 of 54 checks passed
@VachaShah VachaShah deleted the upgrade-go-and-jsondiff branch April 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants