Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: Solve Complains for opensearchtransport #353

Merged

Conversation

Jakob3xD
Copy link
Collaborator

Description

Once #352 is merged I'll rebase this MR.
Update golangci-lint config and bump its version.
Solve linting complains inside opensearchtransport folder.
This is a side product of my current refactoring. I fixed all linting complains in my feature branch and I want to merge some of those fixes upstream to reduce the files changed by my feature branch.

Issues Resolved

There is not open issue for linting.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Jakob3xD Jakob3xD changed the title Jh liniting opensearchtransport golangci-lint: Solve Complains for opensearchtransport Jul 26, 2023
dblock
dblock previously approved these changes Jul 26, 2023
…ctions, make defaults const

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
@Jakob3xD Jakob3xD force-pushed the jh-liniting-opensearchtransport branch from cfc7a56 to b3cd5b8 Compare July 27, 2023 07:07
@dblock dblock merged commit 25b9578 into opensearch-project:main Jul 27, 2023
42 of 43 checks passed
@Jakob3xD Jakob3xD deleted the jh-liniting-opensearchtransport branch July 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants