Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observability event analytics and notebook failing tests #949

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

mengweieric
Copy link
Contributor

Description

#948

Fix observability event analytics and notebook failing tests.

Adding sample visualization
    ✓ Add sample observability data (10158ms)

  Testing notebooks table
    ✓ Creates a notebook and redirects to the notebook (6125ms)
    ✓ Duplicates and renames a notebook (17050ms)
    ✓ Deletes notebooks (14073ms)

  Testing paragraphs
    ✓ Goes into a notebook and creates paragraphs (15351ms)
    ✓ Renders markdown
    ✓ Shows output message (7307ms)
    ✓ Duplicates paragraphs (6804ms)
    ✓ Adds a dashboards visualization paragraph (15066ms)
    ✓ Adds a SQL query paragraph (17729ms)
    ✓ Adds a PPL query paragraph (18266ms)
    ✓ Runs all paragraphs (11655ms)
    ✓ Deletes paragraphs (13078ms)
    ✓ Cleans up test notebooks (10435ms)

  clean up all test data
    ✓ Delete visualizations from event analytics (12384ms)
    ✓ Deletes test panel (10052ms)


  16 passing (3m)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        16                                                                               │
  │ Passing:      16                                                                               │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     3 minutes, 8 seconds                                                             │
  │ Spec Ran:     plugins/observability-dashboards/6_notebooks.spec.js 



       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/observability-dashboards/6_      03:08       16       16        -        -        - │
  │    notebooks.spec.js                                                                           │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        03:08       16       16        -        -        - 


 Click actions
    ✓ Actions - add sample data (10748ms)

  Delete saved objects
    ✓ Delete visualizations/queries from event analytics (14666ms)


  2 passing (25s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      2                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     25 seconds                                                                       │
  │ Spec Ran:     plugins/observability-dashboards/5_event_analytics.spec.js                       │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /home/ubuntu/ws/opensearch-dashboards-functional-test/cypre     (1 second)
                          ss/videos/plugins/observability-dashboards/5_event_analytic               
                          s.spec.js.mp4                                                             


====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/observability-dashboards/5_      00:25        2        2        -        -        - │
  │    event_analytics.spec.js                                                                     │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:25        2        2        -        -        -  

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
@kavilla kavilla merged commit 3b7c9ad into opensearch-project:2.11 Nov 6, 2023
2 of 3 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-949-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b7c9ad26342ff7edb2a8086ec09fd39e5bcc5ec
# Push it to GitHub
git push --set-upstream origin backport/backport-949-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-949-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-949-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b7c9ad26342ff7edb2a8086ec09fd39e5bcc5ec
# Push it to GitHub
git push --set-upstream origin backport/backport-949-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-949-to-main.

@ruanyl
Copy link
Member

ruanyl commented Jan 22, 2024

@mengweieric Could you help me to understand the relation between this PR and #948? Is #948 still needed consider #949 has backport main and backport 2.x?

@mengweieric
Copy link
Contributor Author

@mengweieric Could you help me to understand the relation between this PR and #948? Is #948 still needed consider #949 has backport main and backport 2.x?

I was asked to post fixes directly to 2.11 then backport to main, but later realized that 2.11 tests are different than tests in main therefore posting a PR to fix main differently.

@ruanyl
Copy link
Member

ruanyl commented Jan 26, 2024

@mengweieric Could you help me to understand the relation between this PR and #948? Is #948 still needed consider #949 has backport main and backport 2.x?

I was asked to post fixes directly to 2.11 then backport to main, but later realized that 2.11 tests are different than tests in main therefore posting a PR to fix main differently.

I see, thanks for the reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants