-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move over remaining AD tests; clean up cypress run scripts #89
Conversation
@amitgalitz @ylwu-amzn feel free to add any thoughts you have here as well. A follow-up to this will be removing cypress dependency + tests from AD Dashboards plugin. |
Noticed the test failure which is tracked here #90 @Flyingliuhub is working on a PR to skip it. Once it is done, @ohltyler can merge that one to get rid of the check failure. @ohltyler, I merged the change in already for skipping failed test, it should unblock you now. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
|
||
export const TEST_DETECTOR_ID = 'ulgqpXEBqtadYz9j2MHG'; | ||
|
||
// TODO: when repo is onboarded to typescript we can convert these detector states into an enum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to create a feature request issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@tianleh @Tengda-He please have another quick look at the latest commit when you get the chance. Basically the |
Great dive deep! |
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
This PR moves over the remaining AD cypress tests, including detector list page tests and create detector workflow tests. Refactors the dashboard tests by adding the test suite directly in anomaly-detection folder, instead of abstracting the test in
cypress/integration/common
.It also adds some useful scripts in
package.json
to reduce some code duplication used in the github workflows.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.