Cypress Integ test for dynamic multi-tenancy features #609
Conversation
abhivka7
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc and
peterzhuamazon
as code owners
There was a problem hiding this comment.
Why does this tests have so many wait statements??
Here is an example test that achieves something similar without wait statements: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/basic.spec.js
also refer to to this guide on how to write effective functional tests: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/docs/writing_tests.md
There was a problem hiding this comment.
Thanks Ashwin. I have updated my PR after following your suggestions.
abhivka7
force-pushed
the
Dynamic_MultiTenancy
branch
3 times, most recently
from
b0c4f10 to
2f3d2d5
Compare
|
Team I have run the tests against my PR for Dashboards Security Plugin (https://github.com/opensearch-project/security-dashboards-plugin/pull/1394/files). Can you guys please review and merge this PR? |
| @@ -87,6 +87,22 @@ declare namespace Cypress { | |||
| header: string, | |||
| ): Chainable<S>; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
The comment header here is wrong
There was a problem hiding this comment.
Fixed. Thanks @ashwin-pc for pointing this out.
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
abhivka7
force-pushed
the
Dynamic_MultiTenancy
branch
from
2f3d2d5 to
d2dbd28
Compare
|
Thanks @ashwin-pc and @CCongWang for reviewing this PR. |
Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit 7ec51ed)
Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit 7ec51ed)
…oject#609) (opensearch-project#659) Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit 7ec51ed) Co-authored-by: Abhi Kalra <99718513+abhivka7@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Description
Adding cypress tests for dynamic tenancy feature (opensearch-project/security-dashboards-plugin#1394)
Issues Resolved
Writing cypress tests for: opensearch-project/security-dashboards-plugin#1394
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Video recording for multi_tenancy Test:
https://user-images.githubusercontent.com/99718513/231845323-d896c479-26b3-460d-9f01-2462d92d668b.mp4
Video recording for default_tenant Test:
default_tenant.js.mp4