Revert "move test artifacts to a single dir (#50)" #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c39277e. Signed-off-by: Tianle Huang <tianleh@amazon.com>
seraphjiang
approved these changes
Dec 6, 2021
|
could we add instruction how develop leverage this for troubleshooting to readme/contribution doc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c39277e.
Description
After thinking through the change, this will require all plugin teams to make the same Cypress configuration change. This will be an extra effort for all the teams.
Thus I want to revert this change and make the logic in
infracomplicated. I thought we could just copycypress/resultsand now we will need to copy 3 timescypress/resultscypress/screenshotscypress/videosIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.