-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Observability mapping url #475
Fix Observability mapping url #475
Conversation
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Cypress Test run results for the modified tests: without-security `===================================================================================== (Run Starting) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ ──────────────────────────────────────────────────────────────────────────────────────────────────── Running: plugins/observability-dashboards/0_before.spec.js (1 of 1) Before 1 passing (17s) (Results) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ (Video)
===================================================================================== (Run Finished) with-security `===================================================================================== (Run Starting) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ ──────────────────────────────────────────────────────────────────────────────────────────────────── Running: plugins/observability-dashboards/0_before.spec.js (1 of 1) Before 1 passing (18s) (Results) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ (Video)
===================================================================================== (Run Finished) |
0_before.spec.js.mov |
Hi @kavithacm @ps48 , thanks for the fix, do we need to backport this change to previous versions? If yes, which branch should we backport to? Thanks! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-475-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4a31335c2247ce7c8470ebb0192f1672111b9ab
# Push it to GitHub
git push --set-upstream origin backport/backport-475-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-475-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4a31335c2247ce7c8470ebb0192f1672111b9ab
# Push it to GitHub
git push --set-upstream origin backport/backport-475-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133)
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
…oject#478) Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit d4a3133) Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Signed-off-by: Kavitha Conjeevaram Mohan mohakavi@amazon.com
Description
The
mapping_url
provided for observability seems to be pointing towards the old repository. So changing it to point towards correct URL.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.