Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observability mapping url #475

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

kavithacm
Copy link
Contributor

Signed-off-by: Kavitha Conjeevaram Mohan mohakavi@amazon.com

Description

The mapping_url provided for observability seems to be pointing towards the old repository. So changing it to point towards correct URL.

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm requested a review from a team as a code owner February 3, 2023 19:25
@kavithacm
Copy link
Contributor Author

Cypress Test run results for the modified tests:

without-security

`=====================================================================================

(Run Starting)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 9.5.4 │
│ Browser: Electron 94 (headless) │
│ Node Version: v10.23.1 (/usr/local/bin/node) │
│ Specs: 1 found (plugins/observability-dashboards/0_before.spec.js) │
│ Searched: cypress/integration/plugins/observability-dashboards/0_before.spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: plugins/observability-dashboards/0_before.spec.js (1 of 1)

Before
✓ setup completed (16473ms)

1 passing (17s)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 1 │
│ Passing: 1 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 16 seconds │
│ Spec Ran: plugins/observability-dashboards/0_before.spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

  • Started processing: Compressing to 32 CRF
  • Finished processing: /Users/mohakavi/funtional test repo/opensearch-dashboards-f (2 seconds)
    unctional-test/cypress/videos/plugins/observability-dashboa
    rds/0_before.spec.js.mp4

=====================================================================================

(Run Finished)
`

with-security

`=====================================================================================

(Run Starting)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 9.5.4 │
│ Browser: Electron 94 (headless) │
│ Node Version: v10.23.1 (/usr/local/bin/node) │
│ Specs: 1 found (plugins/observability-dashboards/0_before.spec.js) │
│ Searched: cypress/integration/plugins/observability-dashboards/0_before.spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: plugins/observability-dashboards/0_before.spec.js (1 of 1)

Before
✓ setup completed (18372ms)

1 passing (18s)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 1 │
│ Passing: 1 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 18 seconds │
│ Spec Ran: plugins/observability-dashboards/0_before.spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

  • Started processing: Compressing to 32 CRF
  • Finished processing: /Users/mohakavi/funtional test repo/opensearch-dashboards-f (2 seconds)
    unctional-test/cypress/videos/plugins/observability-dashboa
    rds/0_before.spec.js.mp4

=====================================================================================

(Run Finished)
`

@kavithacm
Copy link
Contributor Author

0_before.spec.js.mov

@CCongWang
Copy link
Collaborator

Hi @kavithacm @ps48 , thanks for the fix, do we need to backport this change to previous versions? If yes, which branch should we backport to? Thanks!

@CCongWang CCongWang merged commit d4a3133 into opensearch-project:main Feb 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-475-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4a31335c2247ce7c8470ebb0192f1672111b9ab
# Push it to GitHub
git push --set-upstream origin backport/backport-475-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-475-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-475-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4a31335c2247ce7c8470ebb0192f1672111b9ab
# Push it to GitHub
git push --set-upstream origin backport/backport-475-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-475-to-1.3.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Cong Wang <conjwang@amazon.com>
mengweieric pushed a commit to mengweieric/opensearch-dashboards-functional-test that referenced this pull request Feb 10, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
mengweieric pushed a commit to mengweieric/opensearch-dashboards-functional-test that referenced this pull request Feb 10, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
…oject#478)

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit d4a3133)

Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants