Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for filter of aggregation view feature #357

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Add test cases for filter of aggregation view feature #357

merged 1 commit into from
Nov 3, 2022

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Oct 31, 2022 •
edited
Loading

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Add test case for filter of aggregation view feature

Issues Resolved

Test Recording

aggregation_view.js.mp4

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997
Add test cases for filter of aggregation view feature
b55d1b2 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@cwperks cwperks mentioned this pull request Oct 31, 2022
Merged
8 tasks
@tianleh
Copy link
Member

tianleh commented Nov 2, 2022

A side note: there is an existing folder security for security dashboards plugin https://github.com/opensearch-project/opensearch-dashboards-functional-test/tree/main/cypress/integration/plugins/security Let me know if it is intentional to keep your test cases in a new folder security-dashboards-plugin.

The workflow is running against security https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.github/workflows/security-release-e2e-workflow.yml#L26

@RyanL1997
Copy link
Contributor Author

A side note: there is an existing folder security for security dashboards plugin https://github.com/opensearch-project/opensearch-dashboards-functional-test/tree/main/cypress/integration/plugins/security Let me know if it is intentional to keep your test cases in a new folder security-dashboards-plugin.

The workflow is running against security https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.github/workflows/security-release-e2e-workflow.yml#L26

Hi @tianleh, thanks for the information. Yes, we intentionally keep our test in a separate folder for following reasons:

  • The aggregation feature test case will not be included in the e2e-workflow for now.
  • The security folder will focus on the testing of fundamental features of security plugin. The test cases for features which were built on these existing fundamental features, will be tested in security-dashboards-plugin folder.

@tianleh
Copy link
Member

tianleh commented Nov 2, 2022

Please mark "Ready for review" when it is ready for review. Since it is not included in the e2e workflow, could you attach the Cypress video when running from your local?

@tianleh
Copy link
Member

tianleh commented Nov 2, 2022

Also please add backport labels if this requires backport.

@RyanL1997
Copy link
Contributor Author

Hi @tianleh, I just uploaded the cypress test recording and this PR is ready for review. Could you please also help me to add the backport labels for both 2.x and 2.4 branch?

@RyanL1997 RyanL1997 marked this pull request as ready for review November 3, 2022 00:25
@RyanL1997 RyanL1997 requested a review from a team as a code owner November 3, 2022 00:25
tianleh
tianleh reviewed Nov 3, 2022
View reviewed changes
cypress/integration/plugins/security-dashboards-plugin/aggregation_view.js
cy.contains('a', 's*');
cy.contains('a', 'se*').should('not.exist');

cy.wait(3000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall have a follow up issue to optimize the wait https://docs.cypress.io/guides/references/best-practices#Unnecessary-Waiting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I will create a follow up for optimize those cy.wait(). Thanks for the reminder!

@tianleh
Copy link
Member

tianleh commented Nov 3, 2022

Hi @tianleh, I just uploaded the cypress test recording and this PR is ready for review. Could you please also help me to add the backport labels for both 2.x and 2.4 branch?

added.

@tianleh tianleh merged commit 37134e9 into opensearch-project:main Nov 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@RyanL1997 @github-actions
Add test cases for filter of aggregation view feature (#357)
e3a4379 
Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 37134e9)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 3, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@RyanL1997 @github-actions
Add test cases for filter of aggregation view feature (#357)
f78e875 
Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 37134e9)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 3, 2022
Merged
tianleh pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @RyanL1997
Add test cases for filter of aggregation view feature (#357) (#363)
71fa768 
Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 37134e9)

Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
tianleh pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @RyanL1997
Add test cases for filter of aggregation view feature (#357) (#364)
f9e0a6d 
Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 37134e9)

Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
@RyanL1997 @jakubp-eliatra
Add test cases for filter of aggregation view feature (opensearch-pro…
a605d5e 
…ject#357)

Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @RyanL1997 @leanneeliatra
Add test cases for filter of aggregation view feature (opensearch-pro…
70bc17d 
…ject#357) (opensearch-project#363)

Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 37134e9)

Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seraphjiang seraphjiang seraphjiang approved these changes

@tianleh tianleh tianleh approved these changes

@CCongWang CCongWang CCongWang approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanL1997 @tianleh @seraphjiang @CCongWang