Fix Cypress Test Flakiness by Executing cy.visit Before cy.request #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses intermittent failures in the AD Cypress tests related to a known issue in Cypress (cypress-io/cypress#25397). The specific failure observed was: ``` Sample detector "before all" hook for "Empty message with modal": AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="viewSampleDetectorLink"]`, but never found it. ``` To mitigate this issue, we applied a workaround suggested in the GitHub issue, ensuring that cy.visit is executed before cy.request. This change helps stabilize the tests by properly loading AD overview page before making any API requests. Testing: * Ran all Cypress tests with the modified code to verify the fix. Signed-off-by: Kaituo Li <kaituo@amazon.com>
kaituo
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
jackiehanyang
approved these changes
Aug 26, 2024
zhongnansu
approved these changes
Aug 26, 2024
CCongWang
approved these changes
Aug 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…1537) This PR addresses intermittent failures in the AD Cypress tests related to a known issue in Cypress (cypress-io/cypress#25397). The specific failure observed was: ``` Sample detector "before all" hook for "Empty message with modal": AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="viewSampleDetectorLink"]`, but never found it. ``` To mitigate this issue, we applied a workaround suggested in the GitHub issue, ensuring that cy.visit is executed before cy.request. This change helps stabilize the tests by properly loading AD overview page before making any API requests. Testing: * Ran all Cypress tests with the modified code to verify the fix. Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit 221231d)
CCongWang
pushed a commit
that referenced
this pull request
Aug 27, 2024
…1537) (#1538) This PR addresses intermittent failures in the AD Cypress tests related to a known issue in Cypress (cypress-io/cypress#25397). The specific failure observed was: ``` Sample detector "before all" hook for "Empty message with modal": AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="viewSampleDetectorLink"]`, but never found it. ``` To mitigate this issue, we applied a workaround suggested in the GitHub issue, ensuring that cy.visit is executed before cy.request. This change helps stabilize the tests by properly loading AD overview page before making any API requests. Testing: * Ran all Cypress tests with the modified code to verify the fix. Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit 221231d) Co-authored-by: Kaituo Li <kaituo@amazon.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses intermittent failures in the AD Cypress tests related to a known issue in Cypress (cypress-io/cypress#25397). The specific failure observed was:
To mitigate this issue, we applied a workaround suggested in the GitHub issue, ensuring that cy.visit is executed before cy.request. This change helps stabilize the tests by properly loading AD overview page before making any API requests.
Testing:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.