Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alerting cypress tests. #1451

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

AWSHurneyt
Copy link
Contributor

@AWSHurneyt AWSHurneyt commented Jul 30, 2024

Description

Fixed cypress tests following PR opensearch-project/alerting#1612

Please backport this PR to 2.x, and 2.13 through 2.16.

Testing

Corresponding PR in the plugin repo that shows the tests pass with security disabled - opensearch-project/alerting-dashboards-plugin#1027

Ran the tests on a security enabled docker domain. Had to run some test suites in chunks as they were running slow on my local machine.
Screenshot 2024-07-29 at 4 18 01 PM
Screenshot 2024-07-29 at 4 26 57 PM
Screenshot 2024-07-29 at 4 32 53 PM
Screenshot 2024-07-29 at 4 43 55 PM
Screenshot 2024-07-29 at 4 50 55 PM
Screenshot 2024-07-29 at 4 54 49 PM
Screenshot 2024-07-29 at 5 00 11 PM
Screenshot 2024-07-29 at 5 14 03 PM
Screenshot 2024-07-29 at 5 22 07 PM
Screenshot 2024-07-29 at 5 23 41 PM
Screenshot 2024-07-29 at 5 34 22 PM
Screenshot 2024-07-29 at 5 40 12 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@SuZhou-Joe
Copy link
Member

Suppose the failure should be flaky, let me rerun the alerting test.

@AWSHurneyt
Copy link
Contributor Author

@SuZhou-Joe Actually, could you remove the 2.13-2.15 backport labels? We don't need to backport these fixes that far. Sorry!

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented Jul 31, 2024

@AWSHurneyt Sure, but the bucket and query cases keep failing, do you know the reason?

@AWSHurneyt AWSHurneyt mentioned this pull request Jul 31, 2024
1 task
@AWSHurneyt
Copy link
Contributor Author

@SuZhou-Joe
@amsiglan ran the tests locally without security, and the screenshots above were run on a security-enabled docker image. They're passing reliably locally. Unsure what could be the difference in the PR execution.

@amsiglan
Copy link
Contributor

amsiglan commented Aug 1, 2024

@SuZhou-Joe @amsiglan ran the tests locally without security, and the screenshots above were run on a security-enabled docker image. They're passing reliably locally. Unsure what could be the difference in the PR execution.

@SuZhou-Joe I have seen in the past that CIs here fail but they are passing in our repo CIs as well as the release test passes, so I think we should be fine merging this change to unblock 2.16 and only spend time investigating if the auto cut issue is not resolved

@SuZhou-Joe
Copy link
Member

@amsiglan @AWSHurneyt I see, I will take your manual sign-off to unblock the 2.16 release. Create an issue #1464 to track.

@SuZhou-Joe SuZhou-Joe merged commit 86599cf into opensearch-project:main Aug 2, 2024
38 of 39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 86599cf)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 86599cf)
SuZhou-Joe pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 86599cf)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 86599cf)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants